Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arch/risc-v/src/cmake/Toolchain.cmake: Msys2 CMake fixed nuttx/config.h: No such file or directory #14961

Merged
merged 1 commit into from
Nov 26, 2024
Merged

arch/risc-v/src/cmake/Toolchain.cmake: Msys2 CMake fixed nuttx/config.h: No such file or directory #14961

merged 1 commit into from
Nov 26, 2024

Conversation

simbit18
Copy link
Contributor

@simbit18 simbit18 commented Nov 26, 2024 •
edited
Loading

Summary

fixed
/qemu-rv/qemu_rv_head.S:25:10: fatal error: nuttx/config.h: No such file or directory
25 | #include <nuttx/config.h>
| ^~~~~~~~~~~~~~~~
compilation terminated.

added

# override the responsible file flag

if(CMAKE_GENERATOR MATCHES "Ninja")
  set(CMAKE_C_RESPONSE_FILE_FLAG "$DEFINES $INCLUDES $FLAGS @")
  set(CMAKE_CXX_RESPONSE_FILE_FLAG "$DEFINES $INCLUDES $FLAGS @")
  set(CMAKE_ASM_RESPONSE_FILE_FLAG "$DEFINES $INCLUDES $FLAGS @")
endif()

same arm issue #14892

Impact

Impact on user: No changes to user-facing functionality
Impact on build: Build process remains the same

Testing

local msys2
cmake -B build -DBOARD_CONFIG=rv-virt:nsh -GNinja
cmake -B build -DBOARD_CONFIG=rv-virt:nsh64 -GNinja

riscv32

@simbit18
arch/risc-v/src/cmake/Toolchain.cmake: Msys2 Cmake fixed nuttx/config…
e56ea7b 
….h: No such file or directory

fixed
/qemu-rv/qemu_rv_head.S:25:10: fatal error: nuttx/config.h: No such file or directory
   25 | #include <nuttx/config.h>
      |          ^~~~~~~~~~~~~~~~
compilation terminated.

added

# override the responsible file flag

if(CMAKE_GENERATOR MATCHES "Ninja")
  set(CMAKE_C_RESPONSE_FILE_FLAG "$DEFINES $INCLUDES $FLAGS @")
  set(CMAKE_CXX_RESPONSE_FILE_FLAG "$DEFINES $INCLUDES $FLAGS @")
  set(CMAKE_ASM_RESPONSE_FILE_FLAG "$DEFINES $INCLUDES $FLAGS @")
endif()
@github-actions github-actions bot added Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Size: XS The size of the change in this PR is very small labels Nov 26, 2024
@simbit18
Copy link
Contributor Author

simbit18 commented Nov 26, 2024 •
edited
Loading

@lupyuen @xiaoxiang781216 perhaps it is better to stop rv-virt/citest

Configuration/Tool: rv-virt/citest is leech of Linux (risc-v-05) !!!

test_open_posix/test_openposix_.py::test_ltp_interfaces_pthread_mutexattr_setpshared_1_1 Killing pytest after timeout...
Terminated
  Normalize rv-virt/citest
HEAD detached at pull/14961/merge
Untracked files:
  (use "git add <file>..." to include in what will be committed)
	boards/risc-v/qemu-rv/rv-virt/configs/citest/logs/
	fatfs.img

nothing added to commit but untracked files present (use "git add" to track)
====================================================================================

unrelated by this PR

@xiaoxiang781216
Copy link
Contributor

should be fixed by #14950, so let's merge this patch directly.

@xiaoxiang781216 xiaoxiang781216 merged commit 430c2ec into apache:master Nov 26, 2024
16 of 17 checks passed
@simbit18 simbit18 deleted the simbit18-riscv branch November 27, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@lupyuen lupyuen lupyuen approved these changes

Assignees
No one assigned
Labels
Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Size: XS The size of the change in this PR is very small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simbit18 @xiaoxiang781216 @lupyuen